Add new ui functions #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple1417
reviewed
Jun 6, 2025
apple1417
requested changes
Jun 6, 2025
There was a problem hiding this comment.
As a general comment, pretty much all of these functions can silently fail - I'm wondering if that's the right thing to do in all cases, I'm not sure where we draw the line. I feel like it's probably fine - though if they can silently fail the description should call it out, like how show_hud_message does.
apple1417
reviewed
Jun 9, 2025
apple1417
requested changes
Jun 12, 2025
src/ui_utils/online_message.py
Outdated
Comment on lines
41
to
43
| def show_message(msg: str) -> None: | ||
| """ | ||
| Displays a message on the left side of the screen. |
There was a problem hiding this comment.
this type still needs a better name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.